Changing how signing and presigning works #526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new method to return the signature while hoisting all headers Added new method to return the signature while hoisting all headers
…presign function or not updated names and using http.Header Update unit test more tests and verified that x-amz-meta-* are not good in query.
…ator Fixed typo Changing to be private
|
Closing because it was merged in release-v1.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #503
Uses Validators object now to do validation instead of blacklists. This allows for more flexible rules. In addition, a new method has been introduced, PresignRequest. This will return a URL with very little headers hoisted and also returns a map of the headers that were hoisted.
With this fix, content-type will be enforced.